Temporarily link to patched version of webvr polyfill #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test out a fix for aframevr#3603
|
Thanks |
|
This has landed? |
|
The linked issue was superseded by one on the upstream: immersive-web/cardboard-vr-display#25 I believe @jsantell landed a PR in that upstream-upstream repo that fixes this: immersive-web/cardboard-vr-display#28 Not sure if it has made it into a webvr-polyfill release (ie what is actually consumed by aframe) yet, though |
|
The change has landed downstream in webvr-polyfill |
|
Cool, want to bump this? |
|
Just released a 0.10.8 version of the polyfill, containing rule matching leniency for Samsung Galaxy devices: immersive-web/webvr-polyfill#332 |
|
@jsantell Thanks for the heads-up, just bumped the version here to match |
|
We're currently using 0.10.8 in master. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test out a fix for #3603
This (probably) shouldn't be merged until the upstream fix (immersive-web/webvr-polyfill#323) is merged in. I'll update this PR at that time